Skip to content

Use system rustc if configured with --enable-local-rust #16321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2014

Conversation

gioele
Copy link
Contributor

@gioele gioele commented Aug 7, 2014

This commit makes the configuration system autodetect a rustc that
is already installed and use that instead of downloading a snapshot.

This commit makes the configuration system autodetect a rustc that
is already installed and use that instead of downloading a snapshot.
@brson
Copy link
Contributor

brson commented Aug 7, 2014

Thanks!

@sfackler
Copy link
Member

sfackler commented Aug 8, 2014

How often would we expect a stage0 build with the local install to actually work?

@huonw
Copy link
Member

huonw commented Aug 8, 2014

I've not had to update any of my Rust CI libraries for more than 2 weeks (as a measure of stability), so this is possibly actually becoming reasonable (in the sense that there's a wider range of rustc's that can compile any given piece of code; although rust-lang/rust is a special case in this respect).

@sfackler
Copy link
Member

sfackler commented Aug 8, 2014

The stage 0 build's more breakable than downstream libraries - wouldn't any #[cfg(stage0)]'d code break almost by definition?

bors added a commit that referenced this pull request Aug 8, 2014
This commit makes the configuration system autodetect a `rustc` that
is already installed and use that instead of downloading a snapshot.
@bors bors closed this Aug 8, 2014
@bors bors merged commit ddeb3db into rust-lang:master Aug 8, 2014
@gioele gioele deleted the use-local-rust branch August 26, 2014 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants